Opened 10 years ago

Last modified 8 years ago

#1459 new enhancement

[PATCH] runtime option to change status line speed

Reported by: djtm@… Owned by: reimar
Priority: normal Component: core
Version: HEAD Severity: minor
Keywords: Cc: compn, hhaamu@…
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

It'd be great if there was a mode that outputs the status on the terminal only e.g. once or twice a second. Probably this should even be the default. This way even small terminals don't suffer, but you still know what's going on.

(I'm talking about this:
A: 0.5 V: 0.5 A-V: -0.013 ct: -0.029 13/ 13 ??% ??% ??,?% 1 0)

Attachments (3)

mplayerquiettime-new-v5.diff (3.4 KB) - added by hhaamu@… 9 years ago.
patch
mplayerquiettime-new-v6.diff (3.5 KB) - added by hhaamu@… 9 years ago.
patch v2
mplayer-quiet-time-2010-06.patch (4.0 KB) - added by djtm@… 8 years ago.
a later patch version after some review

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by hhaamu@…

I'm not subscribed to the mailing list, but I figure the author of the "quiet-time" patch [1] might read this.

I find the option name -quiet-time is rather confusing, and would rather see it named something like "status-delay" or "status-wait" or "quiet-status" or "print-status"

Furthermore, I don't really see why it needs to be in tenths of a second. Milliseconds would do just as well, and would offer more flexibility (4 times per second is impossible now).

[1] http://article.gmane.org/gmane.comp.video.mplayer.devel/53059

Changed 9 years ago by hhaamu@…

patch

comment:2 Changed 9 years ago by hhaamu@…

This is D. Jansen's patch, modified by me according to Reimar's review comments. Most of the credit belongs to D. Jansen.

I took the liberty to:

  • rename the option to "status-rate-max" (it's still a poor name)
  • change it to use milliseconds

I also moved the code to print_status(), since adjust_sync_and_print_status() is only being called for video files.

comment:3 Changed 9 years ago by hhaamu@…

  • Cc hhaamu@… added

Changed 9 years ago by hhaamu@…

patch v2

comment:4 Changed 9 years ago by hhaamu@…

  • attachments.isobsolete changed from 0 to 1

I tend not to notice the flaws in my patch until shortly after submission...

comment:5 Changed 8 years ago by compn

  • Cc patriotact@… added
  • Summary changed from Make quiet more verbose to [PATCH] runtime option to change status line speed

comment:6 Changed 8 years ago by compn

Changed 8 years ago by djtm@…

a later patch version after some review

comment:7 Changed 8 years ago by djtm@…

Good idea to move the code. Really sad this simple tweak hasn't made it. There was some review (http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2009-June/061688.html), I've attached the last patch. In the end nothing came of it.

This patch often makes the difference between playing well and stuttering on my netbook and when using vaapi it reduces the total system cpu usage by about 50 %.

The name was chosen to be similar to -quiet and jump into the eye, as the goal is similar.

comment:8 Changed 8 years ago by reimar

Since it is not visible in the thread view: Please also note my last review http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2009-August/062077.html
The current version of the patch as far as I can tell will after an average of 25 days (depending on the current time - it might happen between right after startup or after 49 days) stop updating the status line for about 49 days.
My review also contains suggested code on how to fix that.

Note: See TracTickets for help on using tickets.