Opened 10 years ago

Last modified 10 years ago

#1685 new defect

ladspd sample freq parameter and crash fix

Reported by: wbreyha@… Owned by: reimar
Priority: normal Component: af
Version: HEAD Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:



I tried to use highpass_iir_1890 filter and found two bugs in af_ladspa.c.

1) It checks parameter boundaries, but doesn't care about LADSPA_IS_HINT_SAMPLE_RATE. So, currently it's impossible to use any plugin which uses this HINT with sane parameters (eg. cutoff frequencies), since values are not multiplied by sample rate. Since the sample rate is not known at this stage in af_ladspa.c I disabled the boundary check in this case and output a warning.

2) mplayer crashes with SIGSEGV because it creates two instances of this mono filter for stereo channels, but it only has a single "activated" flag and so only the first instance gets activated properly. The second one crashes in the moment it is run().

Every plugin with defined activate()-callback and multiple instances will crash.

Regards, Wolfgang Breyha

Attachments (1)

af_ladspa_c_fixes.patch (4.5 KB) - added by wbreyha@… 10 years ago.
fix for both boundary check and crash

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by wbreyha@…

fix for both boundary check and crash

comment:1 Changed 10 years ago by wbreyha@…

comment:2 Changed 10 years ago by reimar

  • Owner changed from reynaldo@… to reimar

Segfault part should be fixed by r31558.

Note: See TracTickets for help on using tickets.