Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2304 closed defect (fixed)

bmovl uses the images stride incorrectly

Reported by: floemker Owned by: beastd
Priority: normal Component: vf
Version: unspecified Severity: blocker
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: yes Analyzed by developer: yes

Description

The bmovl filter allocates memory for a local image. The size of that
memory area is always width * height. But at different locations in the
filter that image is accessed with the incoming images stride as the
width. The stride must be used only when accessing the incoming image.
Otherwise the copied image is distorted.

The attached patch fixes that for me.

mplayer version:

MPlayer 1.3.0-4.8 (C) 2000-2016 MPlayer Team
CPU vendor name: GenuineIntel? max cpuid level: 13
CPU: Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (Family: 6, Model: 60, Stepping: 3)
extended cpuid-level: 8
extended cache-info: 16801856
Detected cache-line size is 64 bytes
CPUflags: MMX: 1 MMX2: 1 3DNow: 0 3DNowExt: 0 SSE: 1 SSE2: 1 SSE3: 1 SSSE3: 1 SSE4: 1 SSE4.2: 1 AVX: 1

Attachments (1)

bmovl-stride.patch (3.4 KB) - added by floemker 3 years ago.
Patch to fix incorrect accessing of the local image in the bmovl filter.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by floemker

Patch to fix incorrect accessing of the local image in the bmovl filter.

comment:1 Changed 3 years ago by beastd

  • Component changed from undetermined to vf
  • Status changed from new to open

I think your changes in regard to chroma are slightly wrong.

Otherwise the patch seems good.

I plan to apply it soon, with some small changes in the chroma parts.

Thanks for reporting and contributing.

comment:2 Changed 3 years ago by beastd

  • Analyzed by developer set
  • Reproduced by developer set
  • Resolution set to fixed
  • Status changed from open to closed

Should be fixed in MPlayer SVN r37901.

Please confirm the fix or re-open this ticket.

comment:3 Changed 3 years ago by floemker

After fixing an unrelated crashing bug in bmovl (ticket #2308)
I can confirm that this works now fine.

Thanks.

Note: See TracTickets for help on using tickets.