Opened 15 years ago

Closed 13 years ago

Last modified 13 years ago

#36 closed defect (fixed)

[PATCH] -wid: get initial window geometry

Reported by: mplayer-bugs@… Owned by: alex@…
Priority: normal Component: vo
Version: HEAD Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

When -wid option is used, most VOs that support it start playing
video at its original (unscaled) size in the top left corner of
the window, and only scale it to the full window upon receipt
of a ConfigureNotify? event, if and when the window is resized.

Also some VOs forget to map the window back after unmapping it
and setting attributes, again when -wid is in use.

Attached patch solved the problem here. It would remove the need
for (some of) ugly hackery in MPlayer frontends.

Attachments (2)

mplayer-wid-1-1.patch (4.8 KB) - added by mplayer-bugs@… 15 years ago.
Patch to fix the above problem
mplayer-wid-1-2.patch (5.1 KB) - added by mplayer-bugs@… 15 years ago.
Updated patch, compiles against the current CVS.

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by mplayer-bugs@…

Patch to fix the above problem

comment:1 Changed 15 years ago by mplayer-bugs@…

cvs diff -u

Adds XGetGeometry and XMapWindow calls where appropriate.

Tested and works here with -vo x11 and -vo xv.

comment:2 Changed 15 years ago by mplayer-bugs@…

  • Summary changed from -wid: get initial window geometry to [PATCH] -wid: get initial window geometry

Changed 15 years ago by mplayer-bugs@…

Updated patch, compiles against the current CVS.

comment:3 Changed 15 years ago by mplayer-bugs@…

  • attachments.isobsolete changed from 0 to 1

The patch would help avoid unnecessary flicker in MPlayer frontends that use
the -wid option.

Please consider.

--
kiriuja

comment:4 Changed 13 years ago by reimar

  • Resolution set to fixed
  • Status changed from new to closed

At least some parts of this patch have been applied, reopen if there are any
problems remaining with latest SVN.

Note: See TracTickets for help on using tickets.