Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#37 closed defect (fixed)

[PATCH] ineffectual video equalizer command line options

Reported by: mplayer-bugs@… Owned by: alex@…
Priority: normal Component: vf
Version: HEAD Severity: normal
Keywords: Cc: reimar
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

Ever since video output's config is called late in initialization
process, -brightness, -contrast, -hue and -saturation command line
options stopped working.

Attached patch fixes them for XVideo and possibly also other VOs.

Attachments (4)

mplayer-vf_vo-1.patch (845 bytes) - added by mplayer-bugs@… 15 years ago.
Patch that solves the above problem for -vo xv
mplayer-vf_vo-2.patch (2.6 KB) - added by mplayer-bugs@… 15 years ago.
New patch per Reimar's suggestion
set_gamma.diff (1.7 KB) - added by reimar 15 years ago.
Different attempt
mplayer-vd-1-1.patch (2.6 KB) - added by mplayer-bugs@… 15 years ago.
Improved patch. Tested & works.

Download all attachments as: .zip

Change History (12)

Changed 15 years ago by mplayer-bugs@…

Patch that solves the above problem for -vo xv

comment:1 Changed 15 years ago by mplayer-bugs@…

cvs diff -u

Removes the check for non-zero vo_config_count.

Assumes (whether correctly or not) that vo::preinit did enough
configuration for VOCTRL_SET_EQUALIZER to succeed or at least
not crash.

comment:2 Changed 15 years ago by reimar

Sorry, but this is an ugly hack and won't be committed.
Maybe moving the set_video_colors calls from mplayer.c,line 1781 to the config
function in libmpcodecs/vf_vo.c would be the better solution...
Would you be ready to create a patch doing this?

Changed 15 years ago by mplayer-bugs@…

New patch per Reimar's suggestion

comment:3 Changed 15 years ago by mplayer-bugs@…

  • attachments.isobsolete changed from 0 to 1

Reimar:

I am attaching a new patch I created per your suggestion.
I tested it and it worked fine with -vo xv.

Unfortunately, as you will see this one is not entirely
hack-free either. I wonder if vf_vo.c needs to be linked
into mencoder.c at all...

So if you have further suggestions, I will be happy to
hear them.

comment:4 Changed 15 years ago by mplayer-bugs@…

  • Cc Reimar.Doeffinger@… added

Changed 15 years ago by reimar

Different attempt

comment:5 Changed 15 years ago by reimar

  • attachments.isobsolete changed from 0 to 1

I think the way this patch does it is the way to go. The only problem that I
can see with this patch, is that it makes the OSD appear and it even never goes
away again...

comment:6 Changed 15 years ago by mplayer-bugs@…

Reimar:

This is actually the way I am doing it in KPlayer, and honestly I don't
like it all that much.

I think I have a better idea, I hope I will have time to implement it
tomorrow.

Changed 15 years ago by mplayer-bugs@…

Improved patch. Tested & works.

comment:7 Changed 15 years ago by mplayer-bugs@…

  • attachments.isobsolete changed from 0 to 1

OK, here we go.

As Reimar suggested, video equalizer levels need to be set
right after VO is configured. So this patch moves the code
from mplayer.c to vd.c, right after it calls VO config.

I tested the patch, it works and causes no adverse side effects.

Please commit.

Thank you.

comment:8 Changed 15 years ago by reimar

  • Resolution set to fixed
  • Status changed from new to closed

Was applied by Sascha Sommer.
Thanks for your efforts.

Note: See TracTickets for help on using tickets.