#378 closed defect (fixed)
-ao pcm:file=filename splits commas from filename!
Reported by: | Owned by: | reimar | |
---|---|---|---|
Priority: | normal | Component: | ao |
Version: | HEAD | Severity: | normal |
Keywords: | Cc: | mplayer@… | |
Blocked By: | Blocking: | ||
Reproduced by developer: | no | Analyzed by developer: | no |
Description
the new syntax for specifying pcm output file (compared to the old -aofile
filename) doesn't support the full range of characters in filename. i
batch-convert my mp3s to wave files with a shell script that does mplayer
FILENAME.mp3 -ao pcm:file=FILENAME.wav. now it doesn't work for files that have
a ',' in the filename; the output file is then set to the part before the comma.
Attachments (2)
Change History (19)
comment:1 by , 19 years ago
comment:2 by , 19 years ago
i've been able to find it on the mailinglist discussion, but there's nothing in
the manual (version 1.0pre7try2). is the "" patch going to make it in?
comment:4 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Oops, forgot: I guess that means this bug is actually fixed.
comment:5 by , 18 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
it's been a while, but no escaping works as of mplayer
dev-CVS-060409-01:31-3.4.6 (latest gentoo ebuild). maybe i'm missing smth? pls
tell me how to use this
comment:6 by , 18 years ago
Version: | 1.0pre7 → CVS |
---|
Right, it doesn't work. The fix only works for files with a ':' in the name, at
least in the -ao pcm:file=... case.
comment:8 by , 18 years ago
Try this, worked for me with the following syntax: mplayer -ao '"pcm:file=a,c"'
comment:9 by , 18 years ago
Owner: | changed from | to
---|---|
Status: | reopened → assigned |
comment:10 by , 18 years ago
while this works, isn't the comma (IIRC) supposed to separate pcm options, i.e.
it should look like this mplayer ... -ao
pcm:file='"a,b"',something_else(dunno_what_it_is_actually)
may be mistaken...
anyway, smth as simple as this should be applied asap. thanks
comment:11 by , 17 years ago
Cc: | added |
---|
comment:14 by , 17 years ago
A patch to allow using , (by writing \,) in -vf parameters was applied
recently, unfortunately it does not seem to help for this case.
It will be resolved when someone writes a proper patch for it. Sorry, but I
have no way to predict when this will be, I personally am too busy with other
things ATM.
by , 17 years ago
Attachment: | mplayer-1.0rc1-understand_escaped_commas.patch added |
---|
patch allowing to escape commas (\,)
comment:15 by , 17 years ago
I guess if I want smth, I just gotta do it myself.
It turned out not to be that hard (although I really do hate coding string manipulation in C - so much hassle). Here's the patch against MPlayer-1.0rc1 that changes the parse_str_list function to ignore LIST_SEPARATOR (',') if it's escaped with '\'. The backslashes are then stripped. What do you think? Seems to work fine and not break anything.
comment:16 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Sorry, forgot to say a simpler patch that also reuses the escaping code that is already there was applied recently.
You can use the %lenght%string syntax described in the man page here. A patch to
allow escaping via "" has not yet been applied...