Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#400 closed defect (fixed)

vf_bmovl doesn't close it's fifo

Reported by: t.dekker@… Owned by: alex@…
Priority: normal Component: vf
Version: HEAD Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

Every time the bmovl filter is loaded it creates a new filepointer, but never
closes it. After a while it errors out with 'Too many open files'.

I think this only happens when you use -fixed-vo in combination with a large
playlist.

I added the following to the uninit function. It seems like this fixes it:

RCS file: /cvsroot/mplayer/main/libmpcodecs/vf_bmovl.c,v
retrieving revision 1.11
diff -u -r1.11 vf_bmovl.c
--- libmpcodecs/vf_bmovl.c 10 Dec 2003 12:28:20 -0000 1.11
+++ libmpcodecs/vf_bmovl.c 29 Oct 2005 04:13:21 -0000
@@ -155,6 +155,7 @@

free(vf->priv->bitmap.v);
free(vf->priv->bitmap.a);
free(vf->priv->bitmap.oa);

+ close(vf->priv->stream_fd);

free(vf->priv);

}

}

Change History (2)

comment:1 Changed 14 years ago by t.dekker@…

You can notice the increase in opened instances with
lsof|grep myfifo.fifo

comment:2 Changed 14 years ago by reimar

  • Resolution set to fixed
  • Status changed from new to closed

Applied with an additional check.

Note: See TracTickets for help on using tickets.