SMIL playlist loading bug

[sonic_amiga@…]

SMIL playlists are XML files so they may have normal XML header like:
<?xml charset=...>

Such SMIL files are created by for example Kino nonlinear video editor. MPlayer can't read them because it thinks that <smil> should be the first tag in the file.
MPlayer should skip line beginning with "<xml" during SMIL detection.

[r_togni@…]

Can you provide a sample file?

Is it safe to assume that the xml tag is in the first line and the smil tag is on the second line? Or it's possible to have other lines between the xml tag and the smil tag?

[sonic_amiga@…]

I think it's safe to assume that <smil> follows <?xml>. At least my files follow this rule.
I've modified my mplayer (playtreeparser.c) in this manner:
--- cut ---

Check if smil
while((line = play_tree_parser_get_line(p)) != NULL) {

strstrip(line);
if(line[0] == '\0') Ignore empties

continue;

if (strncasecmp(line,"<?xml",5)==0)

continue;

if (strncasecmp(line,"<smil",5)==0

strncasecmp(line,"<?wpl",5)==0)

break; smil header found

else

return NULL; line not smil exit

}

--- cut ---
This works okay. I'll bring the sample file tomorrow.
If you're unsure you may introduce another algorythm like this one:
--- cut ---

Check if smil
while((line = play_tree_parser_get_line(p)) != NULL) {

strstrip(line);

if (strncasecmp(line,"<smil",5)==0

strncasecmp(line,"<?wpl",5)==0)

break; smil header found

}
if (line == NULL)

return NULL; line not smil exit

--- cut ---
This will ignore any possible metadata before "<smil>" tag.

[sonic_amiga@…]

A SMIL file created by Kino

[sonic_amiga@…]

Here is the sample.

[r_togni@…]

fixed, applied your first fix