Opened 16 years ago
Closed 16 years ago
#938 closed defect (fixed)
configure check for libdvdnav version is wrong
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Component: | build system |
Version: | HEAD | Severity: | normal |
Keywords: | Cc: | nsabbi@… | |
Blocked By: | Blocking: | ||
Reproduced by developer: | no | Analyzed by developer: | no |
Description
configure line 7519:
$_dvdnavconfig --version --minilibs >> $TMPLOG 2>&1 _dvdnav=no
--minilibs is not a valid option to dvdnav-config in version 0.1.10, which according to checks below should be supported (but I seem to gather that only the mplayer fork is now supported?).
configure line 7530:
_dvdnavvsn=
$_dvdnavconfig --version | sed "s/\.//g"
_dvdnavmajor=echo $_dvdnavvsn | cut -d. -f2
test "$_dvdnavmajor" -ge 2 -o "$_dvdnavvsn" -ge 0110 && \
cc_check $_dvdnavdir $_dvdnavlibs $_ld_dl $_ld_pthread && _dvdnav=yes
$_dvdnavvsn has dots removed by sed.
but $_dvdnavmajor uses dots as a field separator...
so, "$_dvdnavmajor" -ge 2 is pretty much always true, except for something like version 0.0.1
Change History (3)
comment:1 by , 16 years ago
Cc: | added |
---|---|
Status: | new → assigned |
comment:2 by , 16 years ago
correct: the check is wrong. I'll fix it tonighy unless you do
it before me :)
Nico, any input on this?