Opened 11 years ago

Closed 11 years ago

#978 closed enhancement (fixed)

DOCS/xml/Makefile always builds all languages regardless of ./configure --language=...

Reported by: bugs@… Owned by: diego@…
Priority: normal Component: DOCS
Version: HEAD Severity: minor
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

The DOCS/xml/Makefile does not honor the --language=... parameter (or LINGUAS environment variable) given to ./configure, instead it builds all available languages always.

Attachments (2)

mplayer-xml-docs-build-selected-languages-only-r25563.diff (2.7 KB) - added by bugs@… 11 years ago.
Fixes the issue by generting DOC_LANG in config.mak and using it in DOCS/xml/Makefile
mplayer-xml-docs-build-selected-languages-only-r25563.2.diff (3.2 KB) - added by bugs@… 11 years ago.
Added line to ./configure summary output

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by bugs@…

Fixes the issue by generting DOC_LANG in config.mak and using it in DOCS/xml/Makefile

comment:1 Changed 11 years ago by bugs@…

comment:2 Changed 11 years ago by bugs@…

The following block (in my proposed patch)

+ if test "$lang" = en ; then
+ test "$got_en_lang" && continue
+ got_en_lang=1
+ fi

was added to avoid having "en" twice in the DOC_LANG variable (which usually
happens unless --language=all was specified). HTML generation takes a lot of
time, so I felt avoiding duplicates was motivated.

Changed 11 years ago by bugs@…

Added line to ./configure summary output

comment:3 Changed 11 years ago by bugs@…

  • attachments.isobsolete changed from 0 to 1

comment:4 Changed 11 years ago by diego@…

  • Resolution set to fixed
  • Status changed from new to closed

OK, this took quite a long time, but now I finally got around to implementing something based on your patch. Thanks for the effort.

Note: See TracTickets for help on using tickets.