Opened 15 years ago
Closed 15 years ago
#1999 closed defect (fixed)
Compilation fails on Solaris/OpenIndiana due to omission of <alloca.h>
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Component: | build system |
| Version: | HEAD | Severity: | critical |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Reproduced by developer: | no | Analyzed by developer: | no |
Description
Current version (34280) fails to compile on OpenIndiana 148 (Solaris-based), due to lack of inclusion of <alloca.h> in compilation of tremor and loader. The presence of alloca.h is correctly detected by configure, but HAVE_ALLOCA_H is not tested correctly in tremor and loader. The patch below fixes this by correcting tremor/os.h and loader/pe_image.c.
Index: tremor/os.h
===================================================================
--- tremor/os.h (revision 34280)
+++ tremor/os.h (working copy)
@@ -19,6 +19,7 @@
#include <math.h>
#include "os_types.h"
+#include "config.h"
#define STIN static inline
Index: loader/pe_image.c
===================================================================
--- loader/pe_image.c (revision 34280)
+++ loader/pe_image.c (working copy)
@@ -54,6 +54,9 @@
#else
#include "osdep/mmap.h"
#endif
+#ifdef HAVE_ALLOCA_H
+# include <alloca.h>
+#endif
#include "wine/windef.h"
#include "wine/winbase.h"
#include "wine/winerror.h"
Change History (3)
comment:1 by , 15 years ago
| Summary: | Compilation fails on Solaris/OpenIndiana with → Compilation fails on Solaris/OpenIndiana due to omission of <alloca.h> |
|---|
comment:2 by , 15 years ago
| Component: | demuxer → build system |
|---|---|
| Owner: | changed from to |
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |

Patch applied, will push after testing, thanks.