Mencoder return value on exit causes problem

[4Selur@…]

Something changed in the last month that causes Qt's QProcess to assume mencoder exited with a crash.
testing with the builds from ​https://sourceforge.net/projects/mplayerwin/files/MPlayer-MEncoder/

r37831 works fine
r37817 reports a crash
-> something changed between these releases that causes all my Qt based programs to report mencoder as crashing

Don't know a way to reproduce this inside a console/terminal, but I can write some C++ Qt Code to test this if that would help.

[4Selur@…]

Sorry, correction:

r37817 works fine
r37831 reports a crash
the older one works :)

[beastd]

Replying to 4Selur@…:

Sorry, correction:

r37817 works fine
r37831 reports a crash
the older one works :)

IIUC you can easily reproduce the issue. Could you bisect to find out the exact commit that breaks your use case?

[4Selur@…]

Problem is that I have no facility to build the versions myself.
So if you can provide me with 32bit binaries for each of the revisions I can check them and report back.
(Is there a way to browse the svn repository online?)

[4Selur@…]

Friend of mine tested for me:
r37825 works
r37826+ is broken,
-> seems like something changed with r37826

[redxii]

It was probably the fix for #2190.

[beastd]

Replying to 4Selur@…:

Friend of mine tested for me:
r37825 works
r37826+ is broken,
-> seems like something changed with r37826

Thanks.

Unfortunately I could not reproduce the problem here :(

Could you also post the used command line and the console output.

[beastd]

Replying to redxii:

r37826 was probably the fix for #2190.

Are you able reproduce the described mencoder problem?

[redxii]

I don't know about when using it with Qt but from the command-line I am only seeing exit code 0 when mencoder finishes encoding (or something like 'mencoder -oac help'), and I get 1 if I do something like input a wrong parameter or execute mencoder without any parameters.

[4Selur@…]

When calling:

mencoder -lavdopts threads=8 -really-quiet -of rawvideo -o - -ovc raw -noskip -field-dominance -1 -vf scale,format=i420,yadif=0,scale,format=i420 -forcedsubsonly -nosub -nosound -mc 0 "H:\1x05.mkv" | x264 --crf 18.00 --profile high --level 4.1 --direct auto --qcomp 0.5 --no-mbtree --partitions i4x4,p8x8,b8x8 --no-fast-pskip --subme 5 --trellis 0 --weightp 1 --aq-mode 0 --vbv-maxrate 62500 --vbv-bufsize 78125 --sar 16:15 --non-deterministic --range tv --colormatrix bt709 --input-csp i420  --fps 25 --input-res 720x576 --output "H:\Temp\18_57_20_0610_01.264" -

inside a command line everything is fine, but when I call it with Qt it stops near the end since I get a exitCode: -1073740940 and exitStatus: 1 from the QProcess I use, since this only started with the version above and works fine with all the versions before it looks to me like something in mplayer changed,...

[4Selur@…]

removing
+if(mux_v) free(mux_v->buffer);
+if(mux_a) free(mux_a->buffer);
seems to fix it,..

[reimar]

I fixed one issue (related to the mux_v->buffer free) in r37853.
It doesn't really match 100% with your symptoms though, so it would be good to hear if it fixes it or issues remain...

[4Selur@…]

Will check and report back after work

[4Selur@…]

Did a bunch of encodes and r37853 seems to have finished the issue for me.
Thanks for fixing it. :)

[beastd]

Hopefully fully fixed by Reimar in SVN r37853