Opened 18 years ago
Closed 16 years ago
#452 closed defect (worksforme)
MPlayer can't be compiled with glibc 2.0
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Component: | build system |
Version: | HEAD | Severity: | normal |
Keywords: | Cc: | Dominik 'Rathann' Mierzejewski | |
Blocked By: | Blocking: | ||
Reproduced by developer: | no | Analyzed by developer: | no |
Description
This patch fixes compilation of CVS version with glibc 2.0. There are several
issues:
- configure provides fallback definitions of types int_fast8_t, int_fast16_t,
int_fast32_t for systems that don't have them --- but not for int_fast64_t and
uint_fast64_t. Compilation fails because of it.
- IPv6 tests for presence of AF_INET6 but not struct sockaddr_in6. Glibc 2.0
has AF_INET6 but doesn't have sockaddr_in6. Disable IPv6 in such case.
- There are many places where PRI?64 macros are used. libavutil/common.h
provides fallback implementation, but it is not included from many files that
require it.
- libavformat/movenc.c relies on UINT32_MAX, but this glibc doesn't provide it.
Make a fallback definition to 0xffffffffU.
- libavutil/common.h containts definitions for PRIx64, PRId64 etc. for systems
that don't have them, however it lacks definition for PRIX64
- JFIF_major_version and JFIF_minor_version is not defined on older libjpegs.
(disabled for now, there should be configure test for it).
Attachments (1)
Change History (7)
by , 18 years ago
Attachment: | compile.diff added |
---|
comment:1 by , 18 years ago
This patch fixes compiling of CVS version on linux system with glibc 2.0
comment:2 by , 18 years ago
Cc: | added |
---|
./configure part looks ok at first glance, but the rest is rejected:
+ for PRI?64
+#include "../libavutil/common.h"
+
This is unacceptable because it breaks when building with --disable-libavcodec.
A better solution would be to provide a some fallback in osdep/, not include
libavutil headers directly.
libavcodec changes should be posted to ffmpeg-devel for review.
Your solution to 6. is unacceptable, too.
comment:3 by , 18 years ago
Component: | core → build system |
---|---|
Owner: | changed from | to
comment:4 by , 18 years ago
Summary: | Mplayer can't be compiled with glibc 2.0 → MPlayer can't be compiled with glibc 2.0 |
---|
comment:5 by , 18 years ago
Status: | new → assigned |
---|
I have committed the fixes for 1. and 2. The rest needs to be split into small
patches and the libjpeg issue should be handled by configure.
comment:6 by , 16 years ago
rep_platform: | PC (x86 with MMX) → All |
---|---|
Resolution: | → worksforme |
Status: | assigned → closed |
No further information or updated patches were provided, parts were fixed. I will resolve this bug as WORKSFORME for lack of a better category.
fix compilation on glibc 2.0