Memory leak in mpegts.c

[codon1@…]

Hello,

I have found that approximately 250 bytes are leaked everytime we open a mpeg2
transport stream.

I have determined that the leaks are caused by not freeing the codec's extradata
in mpegts_read_close.

Thanks.

[codon1@…]

Patch for freeing the codec's extradata on read_close.

[mans@…]

I'm a bit baffled by this. The MPEGTS demuxer never allocates any extradata,
so there should be none to free as suggested by the patch. Please provide a
test case.

[codon1@…]

Hi,

Sorry I haven't gotten back to you earlier. The extradata is allocated by
av_find_stream_info, not the TS demuxer.

I have noticed that this problem is pervasive across neraly all formats. The
only demuxer I have encountered so far that correctly frees the extradata in
read_close is avidec.c.

I can provide more information or sample content if still required.

[mans@…]

If memory is allocated by generic code, it should be freed by generic code, not
individual demuxers. A leak is still a leak, of course.

[codon1@…]

I agree. av_close_input_file appears to be the appropriate place.

[mans@…]

Fixed the proper way.