Faad file broken!!!!

[x-files@…]

Some change from 16-09-2004 to 20-09-2004 broke faad decode... :(((
If you want I upload faad file... but you can test with any faad file!

See example:
This Works!!!!!!
MPlayer dev-CVS-040915-20:35-3.2.3 (C) 2000-2004 MPlayer Team

CPU: Advanced Micro Devices Athlon Thunderbird 1315 MHz (Family: 6, Stepping: 2)
Detected cache-line size is 64 bytes
CPUflags: MMX: 1 MMX2: 1 3DNow: 1 3DNow2: 1 SSE: 0 SSE2: 0
Compiled with runtime CPU detection - WARNING - this is not optimal!
To get best performance, recompile MPlayer with --disable-runtime-cpudetection.
Reading config file /usr/local/etc/mplayer/mplayer.conf: No such file or directory
Reading config file C:/mplayer/mplayer/config
Reading C:/mplayer/mplayer/codecs.conf: 63 audio & 161 video codecs
Font C:/mplayer/mplayer/font/font.desc loaded successfully! (206 chars)
Using Windows native timing
Input config file C:/mplayer/mplayer/input.conf parsed: 53 binds

Playing x:\samples\Abyss.mp4.
Cache fill: 19.14% (1605632 bytes) QuickTime/MOV file format detected.

---

Warning! pts=1 length=0
MOV track #0: 1 chunks, 0 samples
Generic track - not completely understood! (id: 0)

---

Warning! pts=1 length=0
MOV track #1: 1 chunks, 0 samples
Generic track - not completely understood! (id: 1)

---

Warning! pts=2162160 length=0
MOV track #2: 1644 chunks, 2160 samples
MOV: Found MPEG4 movie Elementary Stream Descriptor atom (105)!
Image size: 704 x 304 (0 bpp)
Display size: 704 x 304
Fourcc: mp4v Codec:

---

Warning! pts=4303872 length=0
MOV track #3: 1647 chunks, 4203 samples
Audio bits: 0 chans: 6 rate: 48000
MOV: Found MPEG4 audio Elementary Stream Descriptor atom (47)!
Fourcc: mp4a

---

Warning! pts=7942936 length=0
MOV track #4: 21 chunks, 21 samples
Generic track - not completely understood! (id: 4)

---

MOV: longest streams: A: #3 (4203 samples) V: #2 (2160 samples)
VIDEO: [mp4v] 704x304 0bpp 23.976 fps 0.0 kbps ( 0.0 kbyte/s)
==========================================================================
Opening audio decoder: [faad] AAC (MPEG2/4 Advanced Audio Coding)
FAAD: compressed input bitrate missing, assuming 128kbit/s!
AUDIO: 48000 Hz, 6 ch, 16 bit (0x10), ratio: 16000->576000 (128.0 kbit)
Selected audio codec: [faad] afm:faad (FAAD AAC (MPEG2/MPEG4 Audio) decoder)
==========================================================================
==========================================================================
Opening video decoder: [ffmpeg] FFmpeg's libavcodec codec family
Selected video codec: [ffodivx] vfm:ffmpeg (FFmpeg MPEG-4)
==========================================================================
Checking audio filter chain for 48000Hz/6ch/16bit -> 48000Hz/2ch/16bit...
AF_pre: af format: 2 bps, 6 ch, 48000 hz, little endian signed int
AF_pre: 48000Hz 6ch Signed 16-bit (Little-Endian)
AO: [win32] 48000Hz 2ch Signed 16-bit (Little-Endian) (2 bps)
Building audio filter chain for 48000Hz/6ch/16bit -> 48000Hz/2ch/16bit...
Starting playback...
VDec: vo config request - 704 x 304 (preferred csp: Planar YV12)
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is 2.32:1 - prescaling to correct movie aspect.
VO: [directx] 704x304 => 704x304 Planar YV12 [fs]
A: 6.3 V: 6.3 A-V: 0.009 ct: 0.063 151/151 28% 13% 9.5% 24 0 61%%
Exiting... (Quit)

With same file, it doesn't work!!!!

MPlayer dev-CVS-040920-00:07-3.3.1 (C) 2000-2004 MPlayer Team

CPU: Advanced Micro Devices Athlon Thunderbird 1187 MHz (Family: 6, Stepping: 2)
Detected cache-line size is 64 bytes
CPUflags: MMX: 1 MMX2: 1 3DNow: 1 3DNow2: 1 SSE: 0 SSE2: 0
Compiled for x86 CPU with extensions: MMX MMX2 3DNow 3DNowEx

Reading config file /usr/local/etc/mplayer/mplayer.conf: No such file or directory
Reading config file X:/Programas Genericos/Mplayer/winmplayer/mplayer/mplayer/config
Reading X:/Programas Genericos/Mplayer/winmplayer/mplayer/mplayer/codecs.conf:
Can't open 'X:/Programas
Genericos/Mplayer/winmplayer/mplayer/mplayer/codecs.conf': No such file or directory
Reading /usr/local/etc/mplayer/codecs.conf: Can't open
'/usr/local/etc/mplayer/codecs.conf': No such file or directory
Using built-in default codecs.conf.
c:/windows/fonts/arial.ttf doesn't look like a font description, ignoring
Cannot load font: c:/windows/fonts/arial.ttf
Using Windows native timing
Input config file X:/Programas
Genericos/Mplayer/winmplayer/mplayer/mplayer/input.conf parsed: 57 binds

Playing x:\samples\Abyss.mp4.
QuickTime/MOV file format detected.

---

Warning! pts=1 length=0
MOV track #0: 1 chunks, 0 samples
Generic track - not completely understood! (id: 0)

---

Warning! pts=1 length=0
MOV track #1: 1 chunks, 0 samples
Generic track - not completely understood! (id: 1)

---

Warning! pts=2162160 length=0
MOV track #2: 1644 chunks, 2160 samples
MOV: Found MPEG4 movie Elementary Stream Descriptor atom (105)!
Image size: 704 x 304 (0 bpp)
Display size: 704 x 304
Fourcc: mp4v Codec:

---

Warning! pts=4303872 length=0
MOV track #3: 1647 chunks, 4203 samples
Audio bits: 0 chans: 6 rate: 48000
MOV: Found MPEG4 audio Elementary Stream Descriptor atom (47)!
Fourcc: mp4a

---

Warning! pts=7942936 length=0
MOV track #4: 21 chunks, 21 samples
Generic track - not completely understood! (id: 4)

---

MOV: longest streams: A: #3 (4203 samples) V: #2 (2160 samples)
VIDEO: [mp4v] 704x304 0bpp 23.976 fps 0.0 kbps ( 0.0 kbyte/s)
==========================================================================
Opening audio decoder: [faad] AAC (MPEG2/4 Advanced Audio Coding)
AUDIO: 48000 Hz, 6 ch, 0 bit (0x10), ratio: 39855->0 (318.8 kbit)
Selected audio codec: [faad] afm:faad (FAAD AAC (MPEG2/MPEG4 Audio) decoder)
==========================================================================
==========================================================================
Opening video decoder: [ffmpeg] FFmpeg's libavcodec codec family
Selected video codec: [ffodivx] vfm:ffmpeg (FFmpeg MPEG-4)
==========================================================================
Checking audio filter chain for 48000Hz/6ch/0bit -> 48000Hz/2ch/16bit...
AF_pre: af format: 0 bps, 6 ch, 48000 hz, little endian signed int
AF_pre: 48000Hz 6ch Unknown
AO: [win32] 48000Hz 2ch Unknown (1 bps)
Building audio filter chain for 48000Hz/6ch/0bit -> 48000Hz/2ch/8bit...
[format] The number of bytes per sample must be 1, 2, 3 or 4. Current value is 0
[libaf] Reinitialization did not work, audio filter 'format' returned error code -2
Couldn't find matching filter / ao format!
Starting playback...
VDec: vo config request - 704 x 304 (preferred csp: Planar YV12)
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is 2.32:1 - prescaling to correct movie aspect.
VO: [directx] 704x304 => 704x304 Planar YV12

Exiting... (Quit)

[x-files@…]

The change is this:
If you readd >>

reset in/out buffer size/pointer:
sh_audio->a_buffer_size=0;
sh_audio->a_buffer=NULL;
sh_audio->a_in_buffer_size=0;
sh_audio->a_in_buffer=NULL;

Set up some common usefull defaults. ad->preinit() can override these:

sh_audio->samplesize=2;
sh_audio->sample_format=AFMT_S16_NE;
sh_audio->samplerate=0;
sh_audio->channels=0;
sh_audio->i_bps=0; input rate (bytes/sec)
sh_audio->o_bps=0; output rate (bytes/sec)

sh_audio->audio_out_minsize=8192;/* default size, maybe not enough for Win32/ACM*/
sh_audio->audio_in_minsize=0;

<< in init_audio_codec resolve the problem!!!

[diego@…]

Which change in which revision of which file?

[reimar]

(In reply to comment #0)

Some change from 16-09-2004 to 20-09-2004 broke faad decode... :(((
If you want I upload faad file... but you can test with any faad file!

A sample is always nice. And I doubt it happens with any faad file, I think it
should only happen with mov and maybe mkv files.
Please try my patch.

[reimar]

Test if this fixes it

[diego@…]

Reimar, I think that commit was yours.

[reimar]

(In reply to comment #5)

Reimar, I think that commit was yours.

And I know it was mine. Maybe I was a bit fast in committing and should have
checked the demuxers better first, but well. The problem exists only in case
where the demuxer sets wrong values in the sh_audio structure, which it IMHO
should never do...
I hope I get around to check them more closely in the next days, but I can't
promise anything, sorry...

[x-files@…]

I upload a sample ftp.mplayerhq.hu/MPlayer/incoming/faad/Abyss.mp4

[x-files@…]

I upload a sample ftp.mplayerhq.hu/MPlayer/incoming/faad/Abyss.mp4
I test the fix and it don't work! Same problem!

[moritz@…]

Setting sh_a->samplesize to 2 has solved this bug in the Matroska demuxer. Maybe
the same can be done in the QT demuxer.

[moritz@…]

*poke* (sorry, setup was broken & Bugzilla didn't send any mails)

[reimar]

Can somebody please comment if this works with current CVS? The sample is
completely broken for me, it isn't even detected as MOV...

[diego@…]

The sample works perfectly for me under Linux, Cygwin and MinGW with CVS from
today --> WORKSFORME. Feel free to REOPEN the bug if it still fails with latest
CVS.