Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1329 closed defect (wontfix)

suggestion: move linix/unix's config dir to $XDG_CONFIG_HOME/mplayer

Reported by: jarryson@… Owned by: reimar
Priority: normal Component: core
Version: unspecified Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: no Analyzed by developer: no

Description

just a little change, to met XDG standards, the config file put in $XDG_CONFIG_HOME( default is ~/.config, glib2 function is g_get_user_config_dir() ), the cache file put in $XDG_CACHE_HOME ( default is ~/.cache, glib2 function is g_get_user_cache_dir() ).

will make $HOME cleaner..here is the patch.

--- get_path.c.orig 2008-10-25 15:25:25.775561356 +0800
+++ get_path.c 2008-10-25 15:33:49.225510568 +0800
@@ -43,6 +43,10 @@

if ((homedir = getenv("MPLAYER_HOME")) != NULL)

config_dir = "";

+ else if ((homedir = getenv("XDG_CONFIG_HOME")) != NULL)
+ config_dir = "/mplayer";
+ else if ((homedir = getenv("XDG_CONFIG_HOME")) == NULL)
+ config_dir = "/.config/mplayer";

else if ((homedir = getenv("HOME")) == NULL)

#if defined(MINGW32)
defined(CYGWIN)

/* Hack to get fonts etc. loaded outside of Cygwin environment. */

Change History (2)

comment:1 by reimar, 15 years ago

Resolution: wontfix
Status: newclosed

MPlayer does not depend on X, it can be used without any Gui from a console and play audio and even video (e.g. via cvidix, libaa, mpeg4yuv to some other application etc.).
Thus I believe that the XDG standards do not apply to it, though I have not found any information on what XDG is supposed to apply to and what not.
I assume it is obvious that without a complete documentation update such a patch is completely unacceptable anyway.

comment:2 by jarryson@…, 15 years ago

infact this is not about what standard stuff, just everyone think put the config file into a common dir do look better. that's for the sake of users. many new Command line applications also do as that. VLC media player also now moved the config file to ~/.config/vlc

but like you say, maybe some other application will use the config file. it's the real problem. so i think better to apply this before the 1.0 version release if you guys want. and only unix/linux version need this change.

just for suggestion. sorry for my english

Note: See TracTickets for help on using tickets.