Opened 11 years ago

Last modified 10 years ago

#1612 new defect

gl shader program variables use incorrect floating point decimal separators in some locales

Reported by: astralstorm@… Owned by: reimar
Priority: normal Component: vo
Version: unspecified Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:


MPlayer SVN-r29963-4.4.1 (C) 2000-2009 MPlayer Team

Shader programs are built using a variant of printf function. This formats floating point numbers in a locale specific way, not the GLSL standard which requires points as separator.

In consequence, mplayer generates invalid shader programs for many locales, e.g. LC_NUMERIC="pl_PL.UTF-8".

The simplest fix is to add setlocale(LC_NUMERIC, "POSIX") somewhere before and restore it afterwards.

I'm sorry I can't provide the patch myself - too busy.

Change History (1)

comment:1 Changed 10 years ago by compn

  • Owner changed from beastd to reimar
Note: See TracTickets for help on using tickets.