Opened 9 years ago

Last modified 9 years ago

#1641 new enhancement

Make it configurable if cropdetect rounds up or down

Reported by: quetschke@… Owned by: reimar
Priority: normal Component: vf
Version: HEAD Severity: minor
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

Currently cropdetect always rounds down crop values for width and height to avoid black bars. Make this configurable and force a round up mode by choosing a negative round value. I know this will leave black borders around the picture and is therefore not optimal for compression efficiency, but it will avoid that picture information is lost.

Attachments (3)

bug_1641.diff (3.5 KB) - added by quetschke@… 9 years ago.
Patch to add proposed functionality.
bug_1641v2.diff (4.4 KB) - added by quetschke@… 9 years ago.
New patch for cropdetect enhancement
bug_1641_man.diff (895 bytes) - added by quetschke@… 9 years ago.
Documentation patch for man page

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by quetschke@…

Patch to add proposed functionality.

comment:1 Changed 9 years ago by quetschke@…

comment:2 Changed 9 years ago by quetschke@…

  • Severity changed from normal to enhancement

comment:3 Changed 9 years ago by quetschke@…

Please disregard my previous patch. It had problems when calculating the x and y offset in "round-up" mode.

The following patch fixes those problems and also includes a work-around for video files where line 0 holds some closed caption information and then the black bars from a letterboxed video follow. This happens frequently with digital SD transmissions in American cable.

Changed 9 years ago by quetschke@…

New patch for cropdetect enhancement

comment:4 Changed 9 years ago by quetschke@…

Changed 9 years ago by quetschke@…

Documentation patch for man page

comment:5 Changed 9 years ago by quetschke@…

comment:6 Changed 9 years ago by quetschke@…

  • attachments.isobsolete changed from 0 to 1

comment:7 Changed 9 years ago by quetschke@…

  • attachments.isobsolete changed from 1 to 0

comment:8 Changed 9 years ago by quetschke@…

  • attachments.ispatch changed from 0 to 1
  • attachments.mimetype changed from text/x-diff to text/plain, 1
Note: See TracTickets for help on using tickets.