Opened 14 years ago

Last modified 13 years ago

#1672 closed defect (worksforme)

./configure --enable-aa does not add -laa flag

Reported by: roidelapluie@… Owned by: reimar
Priority: normal Component: vo
Version: unspecified Severity: trivial
Keywords: Cc: cehoyos
Blocked By: Blocking:
Reproduced by developer: no Analyzed by developer: no

Description

When doing a ./configure --enable-aa, mplayer does not append -laa to LDFLAGS.

And, auto-detecion off aa is corrupted.

#include <aalib.h>
extern struct aa_hardware_params aa_defparams;
extern struct aa_renderparams aa_defrenderparams;
int main(void) {
aa_context *c;
aa_renderparams *p;
(void) aa_init(0, 0, 0);
c = aa_autoinit(&aa_defparams);
p = aa_getrenderparams();
aa_autoinitkbd(c,0);
return 0; }

This segfault at (void) aa_init(0, 0, 0);

here is the patch I made

Index: configure
===================================================================
--- configure (révision 30980)
+++ configure (copie de travail)
@@ -4848,7 +4848,7 @@

int main(void) {
aa_context *c;
aa_renderparams *p;

-(void) aa_init(0, 0, 0);
+(void) aa_init(0, 0, 0);

c = aa_autoinit(&aa_defparams);
p = aa_getrenderparams();
aa_autoinitkbd(c,0);

@@ -4863,6 +4863,8 @@

def_aa='#define CONFIG_AA 1'
if cygwin ; then

libs_mplayer="$libs_mplayer $(aalib-config --libs | cut -d " " -f 2,5,6)"

+ else
+ libs_mplayer="$libs_mplayer -laa"

fi
_vomodules="aa $_vomodules"

else

Change History (2)

comment:1 by compn, 13 years ago

Owner: changed from beastd to reimar

comment:2 by cehoyos, 13 years ago

Resolution: worksforme
Status: newclosed, cehoyos@ag.or.at

--enable-aa works as expected, and I cannot reproduce the crash you see with auto-detection.

Note: See TracTickets for help on using tickets.