Opened 12 years ago

Closed 12 years ago

#858 closed defect (fixed)

tv_usec >= 1000000 is illegal (on NetBSD at least)

Reported by: svs@… Owned by: r_togni@…
Priority: normal Component: streaming
Version: HEAD Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

The code in stream/udp.c and stream/librtsp/rtsp_rtp.c calls select() with tv.tv_usec set to 1000000 (to get a 1-second timeout); it should just set tv_sec to 1 instead.

This code breaks on NetBSD -- itimerfix() (which is ultimately called by select()) rejects such illegal value. See http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/kern/kern_time.c and http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=35444

Attachments (1)

858.diff (780 bytes) - added by svs@… 12 years ago.
proposed fix

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by svs@…

proposed fix

comment:1 Changed 12 years ago by svs@…

comment:2 Changed 12 years ago by compn

  • Resolution set to fixed
  • Status changed from new to closed

diego committed the patch

comment:3 Changed 12 years ago by svs@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

Only to stream/udp.c, but not to stream/librtsp/rtsp_rtp.c

comment:4 Changed 12 years ago by svs@…

Just a friendly reminder -- the fix is still not completely committed...

comment:5 Changed 12 years ago by reimar

  • Resolution set to fixed
  • Status changed from reopened to closed

See r25469.

Note: See TracTickets for help on using tickets.