#102 closed defect (fixed)
mp3lib compiled even with --disable-mp3lib
| Reported by: | Owned by: | reimar | |
|---|---|---|---|
| Priority: | normal | Component: | core |
| Version: | HEAD | Severity: | normal |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Reproduced by developer: | no | Analyzed by developer: | no |
Description
--disable-mp3lib disables mp3lib but still compile and link into mplayer.
Attachments (5)
Change History (15)
by , 20 years ago
| Attachment: | mp3lib.patch added |
|---|
comment:1 by , 20 years ago
by , 20 years ago
| Attachment: | mp3lib.2.patch added |
|---|
patch (v2) do not compile/link mp3lib when --disable-mp3lib
comment:3 by , 20 years ago
+ifeq ($(MP3LIB),yes)
+COMMON_DEPS = mp3lib/libMP3.a
+COMMON_LIBS = mp3lib/libMP3.a
+endif
I guess it should be += here?
And liba52 and libmpeg2 could probably use a modification like this, too. Do you
volunteer to extend your patch? ;-)
comment:4 by , 20 years ago
| attachments.isobsolete: | 0 → 1 |
|---|
(In reply to comment #3)
+ifeq ($(MP3LIB),yes)
+COMMON_DEPS = mp3lib/libMP3.a
+COMMON_LIBS = mp3lib/libMP3.a
+endif
I guess it should be += here?
oops
And liba52 and libmpeg2 could probably use a modification like this, too. Do
you
volunteer to extend your patch? ;-)
done
by , 20 years ago
| Attachment: | disable.2.patch added |
|---|
with additional fix for --disable-liba52 compile
comment:5 by , 20 years ago
MPlayer won't compile with --disable-liba52, had to add some ifdefs...
Can you help me test it a bit with various --disable variants? I'll try to get
this into CVS soon.
comment:6 by , 20 years ago
| attachments.isobsolete: | 0 → 1 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
by , 20 years ago
| Attachment: | disable.3.patch added |
|---|
with more fixes for --disable-(liba52|libmpeg2)
comment:7 by , 20 years ago
small change in configure
- _def_liba52'#undef USE_LIBA52' + _def_liba52='#undef USE_LIBA52'
...
comment:8 by , 20 years ago
| attachments.isobsolete: | 0 → 1 |
|---|
comment:9 by , 20 years ago
I've tried with this:
./configure `./configure --help | gawk '/
--(dis|en)able-/{sub("enable","disable",$1);
if(!match($1,/debug|libavcodec|gcc-checking|dga/)) print $1}'` --disable-dga
and it seems to work, I can't try without libavcodec since my ffmpeg doesn't
have the needed header files.
patch do not compile/link mp3lib when --disable-mp3lib