Opened 15 years ago
Last modified 15 years ago
#1641 new enhancement
Make it configurable if cropdetect rounds up or down
| Reported by: | Owned by: | reimar | |
|---|---|---|---|
| Priority: | normal | Component: | vf |
| Version: | HEAD | Severity: | minor |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Reproduced by developer: | no | Analyzed by developer: | no |
Description
Currently cropdetect always rounds down crop values for width and height to avoid black bars. Make this configurable and force a round up mode by choosing a negative round value. I know this will leave black borders around the picture and is therefore not optimal for compression efficiency, but it will avoid that picture information is lost.
Attachments (3)
Change History (11)
by , 15 years ago
| Attachment: | bug_1641.diff added |
|---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
| Severity: | normal → enhancement |
|---|
comment:3 by , 15 years ago
Please disregard my previous patch. It had problems when calculating the x and y offset in "round-up" mode.
The following patch fixes those problems and also includes a work-around for video files where line 0 holds some closed caption information and then the black bars from a letterboxed video follow. This happens frequently with digital SD transmissions in American cable.
comment:4 by , 15 years ago
comment:5 by , 15 years ago
comment:6 by , 15 years ago
| attachments.isobsolete: | 0 → 1 |
|---|
comment:7 by , 15 years ago
| attachments.isobsolete: | 1 → 0 |
|---|
comment:8 by , 15 years ago
| attachments.ispatch: | 0 → 1 |
|---|---|
| attachments.mimetype: | text/x-diff → text/plain, 1 |
Patch to add proposed functionality.