Opened 5 years ago

Closed 4 years ago

#2208 closed defect (needs_more_info)

vf_fspp.c build problem

Reported by: chris@… Owned by: beastd
Priority: normal Component: vf
Version: HEAD Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: no Analyzed by developer: no

Description

The latest SVN checkout of mplayer (revision 37303) is failing to compile the fspp filter:

cc -MMD -MP -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Werror-implicit-function-declaration -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -D_ISOC99_SOURCE -I. -Iffmpeg -O4 -march=x86-64 -mtune=generic -pipe -ffast-math -fomit-frame-pointer -fno-tree-vectorize -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4  -fpie -DPIC -D_REENTRANT -I/usr/include/p11-kit-1  -I/usr/include/   -D_REENTRANT  -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  -DZLIB_CONST -I/usr/include/opus  -I/usr/include/schroedinger-1.0 -I/usr/include/orc-0.4  -c -o sub/av_sub.o sub/av_sub.c
cc -MMD -MP -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Werror-implicit-function-declaration -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -D_ISOC99_SOURCE -I. -Iffmpeg -O4 -march=x86-64 -mtune=generic -pipe -ffast-math -fomit-frame-pointer -fno-tree-vectorize -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4  -fpie -DPIC -D_REENTRANT -I/usr/include/p11-kit-1  -I/usr/include/   -D_REENTRANT  -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  -DZLIB_CONST -I/usr/include/opus  -I/usr/include/schroedinger-1.0 -I/usr/include/orc-0.4  -c -o libmpcodecs/vf_fspp.o libmpcodecs/vf_fspp.c

libmpcodecs/vf_fspp.c: In function 'column_fidct_mmx':
libmpcodecs/vf_fspp.c:1600:11: error: expected ':' or ')' before 'NAMED_CONSTRAINTS_ADD'
           NAMED_CONSTRAINTS_ADD(ff_MM_FIX_0_707106781,MM_2,MM_FIX_1_414213562_A,MM_FIX_1_414213562,MM_FIX_0_382683433,
           ^
libmpcodecs/vf_fspp.c: In function 'row_idct_mmx':
libmpcodecs/vf_fspp.c:1873:9: error: expected ':' or ')' before 'NAMED_CONSTRAINTS_ADD'
         NAMED_CONSTRAINTS_ADD(MM_FIX_1_414213562_A,MM_FIX_2_613125930,MM_FIX_1_847759065,MM_FIX_1_082392200,
         ^
libmpcodecs/vf_fspp.c: In function 'row_fdct_mmx':
libmpcodecs/vf_fspp.c:2120:9: error: expected ':' or ')' before 'NAMED_CONSTRAINTS_ADD'
         NAMED_CONSTRAINTS_ADD(ff_MM_FIX_0_707106781,ff_MM_FIX_0_541196100,MM_FIX_0_382683433,MM_FIX_1_306562965)
         ^
Makefile:759: recipe for target 'libmpcodecs/vf_fspp.o' failed
make: *** [libmpcodecs/vf_fspp.o] Error 1

This is using gcc v4.9.1 20140903 (prerelease), building on Arch linux.

I'm a bit mystified by the error. Any help would be much appreciated!

Change History (2)

comment:1 Changed 5 years ago by reimar

Does the issue still exist?
It builds fine for me.
This file needs libavutil/x86/asm.h, which can be an issue if you try to build against a FFmpeg version that does not quite match (e.g. a system version of the library instead of the included one).

comment:2 Changed 4 years ago by rxt

  • Resolution set to needs_more_info
  • Status changed from new to closed

Works ok here.
Also you no longer need to manually copy libavutil/x86/asm.h with svn HEAD

Note: See TracTickets for help on using tickets.