Opened 9 years ago
Closed 9 years ago
#2332 closed defect (fixed)
Crash when seeking audio files
| Reported by: | redxii | Owned by: | beastd |
|---|---|---|---|
| Priority: | normal | Component: | undetermined |
| Version: | HEAD | Severity: | critical |
| Keywords: | Cc: | reimar | |
| Blocked By: | Blocking: | ||
| Reproduced by developer: | yes | Analyzed by developer: | yes |
Description
All audio types seem to be affected, including Audio CDs, they play fine but when seeking will trigger signal 11 in 'unknown'. Video files aren't affected.
A really short flac sample is included.
Attachments (2)
Change History (9)
by , 9 years ago
comment:3 by , 9 years ago
| Cc: | added |
|---|
follow-up: 6 comment:5 by , 9 years ago
Following patch fixes the problem here:
--- a/mplayer.c
+++ b/mplayer.c
@@ -4034,7 +4034,7 @@ goto_enable_cache:
}
// reset last frame marker
- if (mpctx->sh_video->frametime < 0)
+ if (mpctx->sh_video && mpctx->sh_video->frametime < 0)
mpctx->sh_video->frametime = 1.0f / mpctx->sh_video->fps;
rel_seek_secs = 0;
abs_seek_pos = 0;
comment:7 by , 9 years ago
| Analyzed by developer: | set |
|---|---|
| Resolution: | → fixed |
| Status: | open → closed |
Committed the suggested patch.
Thank you for the report and confirming the fix!
Note:
See TracTickets
for help on using tickets.
Just the gdb log attached, no sample.
The gdb probably makes zero sense (at least to me), it seems to reference 'mono9_data' (libcaca) but disabling libcaca just changes it to something else.