vo_sdl.c and ao_sdl.c redefine setenv() when Solaris 10 defines it in stdlib.h
| Reported by: |
chrisalbertson90278@… |
Owned by: |
diego@… |
|
Priority:
|
normal
|
Component:
|
build system
|
|
Version:
|
1.0pre7
|
Severity:
|
normal
|
|
Keywords:
|
|
Cc:
|
|
|
Blocked By:
|
|
Blocking:
|
|
|
Reproduced by developer:
|
no
|
Analyzed by developer:
|
no
|
There is a no longer valid test in two files, vo_sdl.c and ao_sdl.c
The test assumes setenv() is undefined if the OS is Solaris. Solaris 10
defines setenv() in stdlib.h
The correct fix would be to check for setenv() in the configure script
then use #if HAVESETENV in the above two .c files. I used a quick hack
and edited the two source files to red "#if 0" and got MPlayer to build
on Solaris 10.
defined(MINGW32) | defined(HPUX) | defined(sgi) | (defined(sun) &&
|
defined(svr4))
/* setenv is missing on win32, solaris, IRIX and HPUX */
Also the exact same code used to define setenv()is in both vo_sdl.c and ao_sdl.c
this maybe should be moved to a common place. I don't know MPlayer well enough
to suggest where
setenv implementation in osdep/