Opened 16 years ago

Closed 15 years ago

#1276 closed defect (fixed)

[PATCH] mov and raw demuxers do not set filepos, so progress stays at 0%

Reported by: rectalogic@… Owned by: r_togni@…
Priority: normal Component: demuxer
Version: HEAD Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: no Analyzed by developer: no

Description

Both the rawvideo and mov demuxers do not update demuxer->filepos and so when transcoding from these formats with mencoder the statusline progress percent stays at 0%.

Attachments (3)

demux_filepos.diff (924 bytes ) - added by rectalogic@… 16 years ago.
patch to fix rawvideo and mov demuxers
demux_filepos2.diff (3.3 KB ) - added by rectalogic@… 16 years ago.
patch for demux_film.c demux_gif.c demux_mf.c demux_rawaudio.c demux_roq.c demux_vqf.c demux_xmms.c
demux_filepos3.diff (3.3 KB ) - added by rectalogic@… 16 years ago.
patch for demux_film.c demux_gif.c demux_mf.c demux_rawaudio.c demux_roq.c demux_vqf.c demux_xmms.c

Download all attachments as: .zip

Change History (10)

by rectalogic@…, 16 years ago

Attachment: demux_filepos.diff added

patch to fix rawvideo and mov demuxers

comment:1 by rectalogic@…, 16 years ago

comment:2 by compn, 16 years ago

op_sys: Mac OS XAll
rep_platform: PC (x86 with SSE)All
Summary: mov and raw demuxers do not set filepos, so progress stays at 0%[PATCH] mov and raw demuxers do not set filepos, so progress stays at 0%

did you check if any other demuxers are missing this? :)

comment:3 by rectalogic@…, 16 years ago

op_sys: AllMac OS X
rep_platform: AllPC (x86 with SSE)

It looks like a few are:

$ grep -L filepos demux_*c
demux_audio.c
demux_avs.c
demux_demuxers.c
demux_film.c
demux_gif.c
demux_mf.c
demux_mpc.c
demux_nemesi.c
demux_rawaudio.c
demux_roq.c
demux_ty_osd.c
demux_vqf.c
demux_xmms.c

I'm attaching a patch for:
demux_film.c
demux_gif.c
demux_mf.c
demux_rawaudio.c
demux_roq.c
demux_vqf.c
demux_xmms.c

Not so sure about the others.

by rectalogic@…, 16 years ago

Attachment: demux_filepos2.diff added

patch for demux_film.c demux_gif.c demux_mf.c demux_rawaudio.c demux_roq.c demux_vqf.c demux_xmms.c

comment:4 by rectalogic@…, 16 years ago

by rectalogic@…, 16 years ago

Attachment: demux_filepos3.diff added

patch for demux_film.c demux_gif.c demux_mf.c demux_rawaudio.c demux_roq.c demux_vqf.c demux_xmms.c

comment:5 by rectalogic@…, 16 years ago

attachments.isobsolete: 01

comment:6 by compn, 16 years ago

i wonder how well it works with demux_mf (mf://*.jpg for example)
thanks for checking and updating patch.

comment:7 by reimar, 15 years ago

Resolution: fixed
Status: newclosed

Code changed to remove the need for the demuxers to set filepos (unless they want to).
It does not work for mf though, since stream_tell won't work for it.

Note: See TracTickets for help on using tickets.