Opened 16 years ago
Closed 15 years ago
#1276 closed defect (fixed)
[PATCH] mov and raw demuxers do not set filepos, so progress stays at 0%
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Component: | demuxer |
Version: | HEAD | Severity: | normal |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Reproduced by developer: | no | Analyzed by developer: | no |
Description
Both the rawvideo and mov demuxers do not update demuxer->filepos and so when transcoding from these formats with mencoder the statusline progress percent stays at 0%.
Attachments (3)
Change History (10)
by , 16 years ago
Attachment: | demux_filepos.diff added |
---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
op_sys: | Mac OS X → All |
---|---|
rep_platform: | PC (x86 with SSE) → All |
Summary: | mov and raw demuxers do not set filepos, so progress stays at 0% → [PATCH] mov and raw demuxers do not set filepos, so progress stays at 0% |
did you check if any other demuxers are missing this? :)
comment:3 by , 16 years ago
op_sys: | All → Mac OS X |
---|---|
rep_platform: | All → PC (x86 with SSE) |
It looks like a few are:
$ grep -L filepos demux_*c
demux_audio.c
demux_avs.c
demux_demuxers.c
demux_film.c
demux_gif.c
demux_mf.c
demux_mpc.c
demux_nemesi.c
demux_rawaudio.c
demux_roq.c
demux_ty_osd.c
demux_vqf.c
demux_xmms.c
I'm attaching a patch for:
demux_film.c
demux_gif.c
demux_mf.c
demux_rawaudio.c
demux_roq.c
demux_vqf.c
demux_xmms.c
Not so sure about the others.
by , 16 years ago
Attachment: | demux_filepos2.diff added |
---|
patch for demux_film.c demux_gif.c demux_mf.c demux_rawaudio.c demux_roq.c demux_vqf.c demux_xmms.c
comment:4 by , 16 years ago
by , 16 years ago
Attachment: | demux_filepos3.diff added |
---|
patch for demux_film.c demux_gif.c demux_mf.c demux_rawaudio.c demux_roq.c demux_vqf.c demux_xmms.c
comment:5 by , 16 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:6 by , 16 years ago
i wonder how well it works with demux_mf (mf://*.jpg for example)
thanks for checking and updating patch.
comment:7 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Code changed to remove the need for the demuxers to set filepos (unless they want to).
It does not work for mf though, since stream_tell won't work for it.
patch to fix rawvideo and mov demuxers