Opened 15 years ago

Closed 14 years ago

#1372 closed defect (fixed)

missing break in reorder_ch

Reported by: wbrana@… Owned by: reynaldo@…
Priority: normal Component: af
Version: unspecified Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: no Analyzed by developer: no

Description

break for case 3 is missing in code in multiple lines in file libaf/reorder_ch.c

Attachments (1)

mplayer-3bytes.diff (1.6 KB ) - added by wbrana@… 15 years ago.
patch

Download all attachments as: .zip

Change History (5)

by wbrana@…, 15 years ago

Attachment: mplayer-3bytes.diff added

patch

comment:1 by wbrana@…, 15 years ago

comment:2 by reynaldo@…, 15 years ago

Resolution: invalid
Status: newclosed

Quickly skimming it doesn't seem like your patch is solving any bug, does it?
Please explain. Just so you know; breaks are not actually mandatory.

comment:3 by wbrana@…, 15 years ago

Resolution: invalid
Status: closedreopened

without patch stderr is flooded with following line if samplesize==3:

mp_msg(MSGT_GLOBAL, MSGL_WARN,

"[reorder_ch] Unsupported sample size: %d, please "
"report this error on the MPlayer mailing list.\n",samplesize);

comment:4 by reynaldo@…, 14 years ago

Resolution: fixed
Status: reopenedclosed

Fixed with r29541

Note: See TracTickets for help on using tickets.