Opened 11 years ago

Closed 10 years ago

#1372 closed defect (fixed)

missing break in reorder_ch

Reported by: wbrana@… Owned by: reynaldo@…
Priority: normal Component: af
Version: unspecified Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

break for case 3 is missing in code in multiple lines in file libaf/reorder_ch.c

Attachments (1)

mplayer-3bytes.diff (1.6 KB) - added by wbrana@… 11 years ago.
patch

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by wbrana@…

patch

comment:1 Changed 11 years ago by wbrana@…

comment:2 Changed 11 years ago by reynaldo@…

  • Resolution set to invalid
  • Status changed from new to closed

Quickly skimming it doesn't seem like your patch is solving any bug, does it?
Please explain. Just so you know; breaks are not actually mandatory.

comment:3 Changed 11 years ago by wbrana@…

  • Resolution invalid deleted
  • Status changed from closed to reopened

without patch stderr is flooded with following line if samplesize==3:

mp_msg(MSGT_GLOBAL, MSGL_WARN,

"[reorder_ch] Unsupported sample size: %d, please "
"report this error on the MPlayer mailing list.\n",samplesize);

comment:4 Changed 10 years ago by reynaldo@…

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed with r29541

Note: See TracTickets for help on using tickets.