SIGSEGV playing a wav file

[ggrieco]

Summary of the bug:

SIGSEGV playing a wav file. Tested in mplayer svn 2015-12-18

How to reproduce:

mplayer -vo null -ao null (testcase attached)

backtrace:

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
MPlayer SVN-r37563-snapshot-4.8 (C) 2000-2015 MPlayer Team

Playing SIGSEGV.PC.5555558f165d.STACK.c27a04484.CODE.1.ADDR.(nil).INSTR.mov____(%rax),%r9.fuzz.
libavformat version 57.20.100 (internal)
Audio only file format detected.
Load subtitles in ./
==========================================================================
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
libavcodec version 57.18.100 (internal)
ADecoder init failed :(
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
ADecoder init failed :(
Opening audio decoder: [hwmpa] MPEG audio pass-through (fake decoder)
Cannot sync MPA frame: 0
ADecoder init failed :(
Opening audio decoder: [spdif] libavformat/spdifenc audio pass-through decoder.
AUDIO: 48000 Hz, 2 ch, mpeg2, 768.0 kbit/50.00% (ratio: 96000->192000)
Selected audio codec: [spdifmpa] afm: spdif (libavformat/spdifenc MPEG AUDIO BC pass-through decoder)
==========================================================================
AO: [null] 48000Hz 2ch mpeg2 (1 bytes per sample)
Video: no video
Starting playback...

Program received signal SIGSEGV, Segmentation fault.
0x00005555558f165d in compute_muxer_pkt_fields ()
#0  0x00005555558f165d in compute_muxer_pkt_fields ()
#1  0x00005555558f25a8 in av_write_frame ()
#2  0x00005555557e679f in decode_audio ()
#3  0x00005555557260c1 in mp_decode_audio ()
#4  0x00005555556a155b in main ()

valgrind report:

MPlayer SVN-r37563-snapshot-4.8 (C) 2000-2015 MPlayer Team

Playing SIGSEGV.PC.5555558f165d.STACK.c27a04484.CODE.1.ADDR.(nil).INSTR.mov____(%rax),%r9.fuzz.
libavformat version 57.20.100 (internal)
Audio only file format detected.
Load subtitles in ./
==========================================================================
Requested audio codec family [mpg123] (afm=mpg123) not available.
Enable it at compilation.
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
libavcodec version 57.18.100 (internal)
Could not open codec.
ADecoder init failed :(
ADecoder init failed :(
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
Could not open codec.
ADecoder init failed :(
ADecoder init failed :(
Requested audio codec family [mad] (afm=libmad) not available.
Enable it at compilation.
Opening audio decoder: [hwmpa] MPEG audio pass-through (fake decoder)
Cannot sync MPA frame: 0
ADecoder init failed :(
ADecoder init failed :(
Opening audio decoder: [spdif] libavformat/spdifenc audio pass-through decoder.
AUDIO: 48000 Hz, 2 ch, mpeg2, 768.0 kbit/50.00% (ratio: 96000->192000)
Selected audio codec: [spdifmpa] afm: spdif (libavformat/spdifenc MPEG AUDIO BC pass-through decoder)
==========================================================================
AO: [null] 48000Hz 2ch mpeg2 (1 bytes per sample)
Video: no video
Starting playback...
[spdif @ 0x1357b20]Encoder did not produce proper pts, making some up.
==7424== Invalid read of size 8
==7424==    at 0x4A565D: compute_muxer_pkt_fields (in /home/vagrant/repos/mplayer-export-2015-12-18/mplayer)
==7424==    by 0x4A65A7: av_write_frame (in /home/vagrant/repos/mplayer-export-2015-12-18/mplayer)
==7424==    by 0x39A79E: decode_audio (in /home/vagrant/repos/mplayer-export-2015-12-18/mplayer)
==7424==    by 0x2DA0C0: mp_decode_audio (in /home/vagrant/repos/mplayer-export-2015-12-18/mplayer)
==7424==    by 0x25555A: main (in /home/vagrant/repos/mplayer-export-2015-12-18/mplayer)
==7424==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==7424== 

[rxt]

Normal playback is ok, fails only with -ao null when spdif decoder is invoked.
Proposed patch is on the devel mailinglist, but I need to be sure that it does not break anything before applying it.

[rxt]

Fixed with r37605 in HEAD, and r37606 in 1.2 branch.