fullscreen disables stay-on-top

[tomasgroth@…]

When using the latest CVS with the follwing command:
mplayer <videofile> -ontop -fs
and the press "f" to disable fullscreen, the ontop feature is disabled as well,
which it shouldn't. I more or less tracked the problem down to x11_common.c
version 1.173-1.174, and made a little patch which makes it work, but since i'm
not familiar with the rest of the code i don't know how it will affect other setups.

patch:
Index: libvo/x11_common.c
===================================================================
RCS file: /cvsroot/mplayer/main/libvo/x11_common.c,v
retrieving revision 1.176
diff -u -r1.176 x11_common.c
--- libvo/x11_common.c 8 Aug 2004 23:22:04 -0000 1.176
+++ libvo/x11_common.c 26 Sep 2004 18:16:21 -0000
@@ -1462,11 +1462,12 @@

vo_x11_sizehint(x, y, w, h, 0);
vo_x11_setlayer(mDisplay, vo_window, vo_fs);

• if ((!(vo_fs)) & vo_ontop)
• vo_x11_setlayer(mDisplay, vo_window, vo_ontop);

XMoveResizeWindow(mDisplay, vo_window, x, y, w, h);

}

+ if ((!(vo_fs)) & vo_ontop)
+ vo_x11_setlayer(mDisplay, vo_window, vo_ontop);
+

#ifdef HAVE_XINERAMA

vo_x11_xinerama_move(mDisplay, vo_window);

#endif

[diego@…]

Patch committed by Alexander Strasser, marking FIXED.

[tomasgroth@…]

Since this bug still apears with lastest CVS (02022005) and XFCE 4.2 i'm
reopening it.
I guess the problems lies in the way -fs and -ontop are activated when use from
the commandline, since the problem only exist when mplayer is used like this:
mplayer <videofile> -ontop -fs
and the fullscreen is deactivated during playback.

When mplayer is used like this:
mplayer <videofile> -ontop
and the fullscreen is activated and then deactivated during playback, the
problem doesn't exist.

[diego@…]

I cannot reproduce this with XFce 4.1. Alexander, can you look into this?

[diego@…]

I can reproduce this bug with XFce 4.2, beastd, can you look into this?

[reimar]

Grr... I'm severely missing a retest state. Latest reply is almost one year
old. Please reopen if it doesn't work again in latest XFce, esp. if you have
any indication it is not a XFce bug/feature.

[tomasgroth@…]

The bug still exists with xfce4 4.2.3, as described in comment #2.

[reimar]

hack that seems to fix the problem

[reimar]

This patch seems to fix it, but I don't intend to apply unless someone finds
out _why_ it helps. My best guess so far is XFce bug, but my knowledge of this
stuff is very limited.