Opened 14 years ago

Closed 10 years ago

#318 closed defect (fixed)

libmpeg2 reinits on some files

Reported by: compn Owned by: reimar
Priority: normal Component: vd
Version: HEAD Severity: normal
Keywords: Cc: nsabbi@…
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

libmpeg2 reinits on some files

VO: [directx] 720x480 => 720x540 Planar YV12
VDec: vo config request - 720 x 480 (preferred csp: Planar YV12)1 0
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is 1.33:1 - prescaling to correct movie aspect.
VO: [directx] 720x480 => 720x540 Planar YV12
VDec: vo config request - 720 x 480 (preferred csp: Planar YV12)2 0
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is 1.33:1 - prescaling to correct movie aspect.

over and over again.

Nico says: The reinit happens when libmpeg2 finds a sequence_header (0x1b3)
after a sequence_end (0x189) IIRC

Attachments (1)

mpeg2reinit.diff (2.0 KB) - added by reimar 12 years ago.
avoid useless reinit

Download all attachments as: .zip

Change History (10)

comment:1 Changed 14 years ago by compn

workaround is to -vc ffmpeg12

comment:2 Changed 14 years ago by nsabbi@…

sequence_end is 0x1B9 not 0x189

comment:4 Changed 13 years ago by diego@…

  • Cc nsabbi@… added

Is this still an issue?

comment:5 Changed 13 years ago by compn

(In reply to comment #4)

Is this still an issue?

tested with MPlayer 20060312-4.1.0, still reinits

Changed 12 years ago by reimar

avoid useless reinit

comment:6 Changed 12 years ago by reimar

Please test. This avoids the reinit, unfortunately libmpeg2 still can't play
still images as in the sample.

comment:7 Changed 12 years ago by reimar

  • Owner changed from r_togni@… to Reimar.Doeffinger@…
  • Status changed from new to assigned

comment:8 Changed 12 years ago by elupus@…

The patch fixes the issue partly. However, there still seam to be another issue at play. (btw, using static variables when there is a nice context struct is kinda uggly :).

There seem to be a memleak in these types of files with libmpeg2. using either vc ffmpeg2 or a vo null stops the leak from occuring. I'm not sure what is going on, and i've not been able to test the file refered to in this post, but i've uploaded a memleak_sample.vob that has the memleak and the reinit vo issue.

secondly, shouldn't the fix be in mpcodecs_config_vo instead, as that would also remove the need for the check in other decoders.

I'm on mingw/xbox, so I suppose that could be playing some part. But i doubt it.

comment:9 Changed 10 years ago by compn

  • Resolution set to fixed
  • Status changed from assigned to closed

ffmpeg12 is now default, closing libmpeg2 bugs

Note: See TracTickets for help on using tickets.