Opened 12 years ago

Last modified 7 years ago

#372 new enhancement

MPEG-PES aka DVB resolution decrease not honored

Reported by: bugs@… Owned by: reimar
Priority: normal Component: vf
Version: HEAD Severity: minor
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

If the resolution decreases from say 720x576 -> 704x576 during playback, the
picture becomes garbled (skewed), however an increase from 704x576 -> 720x576
works.

I noticed that the relevant variables are updated only when the resolution
increases. I fixed it to always update the variables by commenting out the
"offending" if statement. As a result, resolution changes work both ways for me
at least with the following commands:

mencoder -ovc lavc -lavcopts vcodec=mpeg4 -scale 512:384
mencoder -ovc lavc -lavcopts vcodec=mpeg4
mplayer -vo x11
mplayer -vo xv

I'll add the patch that works for me. It patches against both 1.0pre7try2 and
CVS.

The fix also revealed another "bug" in the vd component, I'll post a separate
bug for that one.

[I marked this as an enhancement since Bug 190 states mid-stream resolution
changes are not officially supported.]

Attachments (1)

mplayer-mpegpes-resolution-change-fix-1.0pre7try2-1.patch (1.0 KB) - added by bugs@… 12 years ago.
Fix along with a comment describing a slightly more optimal solution.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by bugs@…

Fix along with a comment describing a slightly more optimal solution.

comment:1 Changed 12 years ago by bugs@…

comment:2 Changed 10 years ago by bugs@…

The following block (in my proposed patch)

+ if test "$lang" = en ; then
+ test "$got_en_lang" && continue
+ got_en_lang=1
+ fi

was added to avoid having "en" twice in the DOC_LANG variable (which usually happens unless --language=all was specified). HTML generation takes a lot of time, so I felt avoiding duplicates was motivated.

comment:3 Changed 10 years ago by bugs@…

(In reply to comment #2)

The following block (in my proposed patch)

Apologizes. I pasted the comment to the wrong bug. Please ignore.

comment:4 Changed 7 years ago by compn

  • Owner changed from alex@… to reimar
Note: See TracTickets for help on using tickets.