#668 closed defect (fixed)
MEncoder opens .sub files as text, outputs corrupt .sub files
| Reported by: | Owned by: | reimar | |
|---|---|---|---|
| Priority: | normal | Component: | core |
| Version: | 1.0rc1 | Severity: | normal |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Reproduced by developer: | no | Analyzed by developer: | no |
Description
When extracting vobsub subtitles, MEncoder (vobsub.c, line 1360) opens the
".sub" file in text mode. Under Windows (and probably other OSs), this results
in all 0x0A (LF) characters being replaced with 0x0D0A (CR LF) sequences, with
the obvious result that the output file is corrupted.
Change History (3)
comment:1 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 17 years ago
I have reviewed the changes. There is just one thing I am unsure of. The
".idx" file is a text file, but it is opened in binary mode for both input
(vobsub.c, line 1088) and output (vobsub.c, line 1365). Is this intentional?
comment:3 by , 17 years ago
This is at least now intentional. I don't think mencoder should produce
different output on windows from linux, and IIRC (correct me if I'm wrong) the
text subtitle formats are also written like that.
Note:
See TracTickets
for help on using tickets.
Should be fixed in SVN r21460