Opened 12 years ago

Last modified 9 years ago

#746 new defect

metadata tags are named inconsistently in demux_*.c files

Reported by: andrei@… Owned by: reimar
Priority: normal Component: demuxer
Version: 1.0rc1 Severity: normal
Keywords: Cc:
Blocked By: Blocking:
Reproduced by developer: Analyzed by developer:

Description

get_meta_* commands cannot report tag fields for Ogg and many other formats. This may cause problems for frontends which rely on MPlayer for metadata processing.

The reason is that get_meta_* commands search the demuxer->info list for the following tag strings: "Title", "Artist", "Album", "Year", "Comment", "Track", and "Genre" (mplayer.c:566-585). The search is case-sensitive (mplayer.c:488).

However, the majority of demux_*.c files do not respect this when filling demuxer->info. For example, demux_ogg.c uses "Name" instead of "Title" and "Comments" instead of "Comment". Many demuxer drivers use low-case names. In many cases, "Author" is used instead on "Artist", which may be logical (especially for video clips), but there is no get_meta_author command to request this information.

Attachments (1)

mplayer-tags.diff (11.8 KB) - added by andrei@… 12 years ago.
the simplest patch

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by andrei@…

the simplest patch

comment:1 Changed 12 years ago by andrei@…

This is the most plain patch: tag names used in demux_info_add invocations are "normalized". Probably, a better solution would be to rename "Year" to "Date" throughout and also to introduce a separate request get_meta_author (to be distinguished from _artist).

comment:2 Changed 9 years ago by compn

  • Owner changed from r_togni@… to reimar
Note: See TracTickets for help on using tickets.